Fix StorageGlobber test suite errors on Windows#39
Merged
noirbizarre merged 1 commit intonoirbizarre:masterfrom Jun 27, 2014
Merged
Fix StorageGlobber test suite errors on Windows#39noirbizarre merged 1 commit intonoirbizarre:masterfrom
noirbizarre merged 1 commit intonoirbizarre:masterfrom
Conversation
The StorageGlobber tests were failing on windows because the paths get normalized to use two slashed by os.path.join. Fixed by normalizing all paths in StorageGlobber and changing expected results in the tests to use the normalized form.
noirbizarre
added a commit
that referenced
this pull request
Jun 27, 2014
Fix StorageGlobber test suite errors on Windows
Owner
|
Thanks (I don't test on Windows so I can't discover these issues) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The StorageGlobber tests were failing on windows
because the paths get normalized to use two slashed by os.path.join.
Fixed by normalizing all paths in StorageGlobber and changing
expected results in the tests to use the normalized form.