Added initial PEP8 rc file

noirbizarre · noirbizarre · commit 7a9638070b9c · 2013-07-23T15:11:35.000+02:00
diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst
@@ -65,6 +65,12 @@ and ensure the documentation is generating.
     $ pip install tox
     $ tox
 
+You also need to ensure your code is PEP8 compliant (following the project rules: see ``pep8.rc`` file):
+
+.. code-block:: console
+
+    $ make pep8
+
 
 **Don't forget client-side code and tests.**
 
diff --git a/Makefile b/Makefile
@@ -37,7 +37,8 @@ coverage:
 	@coverage report --rcfile=coverage.rc
 
 pep8:
-	@pep8 $(PACKAGE) --max-line-length=120 --ignore=E128,E122,E125 && echo 'PEP8: OK'
+	@pep8 $(PACKAGE) --config=pep8.rc
+	@echo 'PEP8: OK'
 
 pylint:
 	@pylint --rcfile=pylint.rc $(PACKAGE)
@@ -47,9 +48,8 @@ doc:
 	@cd $(DOCDIR) && make html
 	@echo 'Done'
 
-dist:
+dist: minify
 	@echo 'Generating a distributable python package'
-	@./minify.sh
 	@python setup.py sdist
 	@echo 'Done'
 
diff --git a/djangojs/tests/test_context.py b/djangojs/tests/test_context.py
@@ -234,7 +234,7 @@ def test_user_disabled(self):
     def test_context_whitelist(self):
         '''Should only include context variable from settings.JS_CONTEXT if set'''
         result = self.process_request()
-        self.assertEqual(len(result.keys()), 2 + 1)  #: User is always in context
+        self.assertEqual(len(result.keys()), 2 + 1)  # User is always in context
         self.assertIn('STATIC_URL', result)
         self.assertIn('LANGUAGE_CODE', result)
 
diff --git a/pep8.rc b/pep8.rc
@@ -0,0 +1,3 @@
+[pep8]
+ignore = E128,E122,E125
+max-line-length = 120

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+[pep8]`
	`2`	`+ignore = E128,E122,E125`
	`3`	`+max-line-length = 120`